PrashantBhanage opened a new pull request, #13696: URL: https://github.com/apache/cloudstack/pull/13696
### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [x] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): N/A — backend-only change, no UI impact. ### How Has This Been Tested? - Added unit tests for the TTL guard behavior. - Verified repeated scrapes within the refresh interval reuse cached metrics. - Verified scrapes after the interval trigger a new metrics recomputation. - Built the Prometheus integration module successfully. #### How did you try to break this feature and the system with this change? - Sent concurrent `/metrics` scrape requests to verify the bounded executor and synchronization prevent overlapping recomputation. - Verified the executor shuts down cleanly in `stop()`. - Verified changing `prometheus.exporter.metrics.min.refresh.interval` at runtime changes the refresh behavior without requiring a restart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
