jball-resetdata commented on issue #13745: URL: https://github.com/apache/cloudstack/issues/13745#issuecomment-5142662188
Some findings from working on the fix, for anyone else who hits this: **The setting is poorly named — it is not a VPC toggle.** `routed.network.vpc.enabled` does not gate VPC as a feature at all: NATTED VPCs and networks are unaffected by it. What it actually gates is the routed-mode / dynamic-routing feature family — ROUTED mode networks, ROUTED mode VPCs, and the BGP peer / AS number range / routed subnet resources. The name (and its description, *"If true, the Routed network and VPC are enabled in the zone."*) reads as a VPC switch, which is exactly what makes the silent API removal so hard to diagnose. **Scope of the upcoming PR:** intentionally minimal — no behavioural change to the toggle itself. It (1) registers the ~26 commands unconditionally so they are always discoverable via `listApis` (the current gate also reads only the *global* value of a *zone-scoped* setting, so per-zone overrides have no effect on API availability today), (2) keeps the existing zone-scoped enforcement at execution time and makes those errors name the setting and zone — i.e. useful error messaging instead of "command does not exist", and (3) clarifies the setting's description string. A rename/split of the toggle needs a config-migration path and is left as a follow-up if maintainers agree on a direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
