Dogface2k commented on PR #13766: URL: https://github.com/apache/cloudstack/pull/13766#issuecomment-5155610779
### Follow-up validation and lifecycle hardening Commit `98cd4ed6f4` adds the lifecycle hardening identified by live NSX validation. - The existing marked-for-deletion retry is now shared by route-based session creation and the complete static-route/NO_SNAT programming operation. It remains bounded at 24 attempts with a 15-second interval. - `NsxApiClientTest.testAddVpnConnectionRoutesRetriesMarkedForDeletion` forces the NSX marked-for-deletion response during route creation and verifies the deterministic route is retried before NO_SNAT programming continues. - State changes use a read-modify-write of the existing route-based session, preserving the mandatory `tunnel_interfaces` field implicated by the pre-deploy failure. - VPN connection, gateway, customer-gateway, and VPC lifecycle operations use VPC-scoped synchronization and deterministic cleanup. Live validation on 4.22.1.0 with NSX 4.2.4 used an intentionally unreachable RFC 5737 test peer. The connection reached `Disconnected`; the first reset reproduced the marked-for-deletion 431, the same reset succeeded after the purge window, and connection/customer-gateway/VPN-gateway/VPC deletion completed with the dedicated test IP released. No production connection was modified, and no tunnel-traffic success is claimed from this test peer. The supplied pre-deploy `tunnel_interfaces` error is a distinct historical failure; the current read-modify-write path passed the stop half of the live reset test. The local checkout has no JDK/Maven executable, so the new focused test must be run by repository CI; `git diff --check` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
