DaanHoogland commented on issue #13892: URL: https://github.com/apache/cloudstack/issues/13892#issuecomment-5314994245
Found a related case while writing wiring tests (issue #10752): `ManagementServer.Ovm3HeartBeatTimeout`/`Ovm3HeartBeatInterval` (`server/src/main/java/com/cloud/server/ManagementServer.java:184-188`) have **zero consumers anywhere in the codebase** — `Ovm3Discoverer` never populates `ovm3.heartbeat.timeout`/`ovm3.heartbeat.interval` into the params map that `Ovm3Configuration.java:112,115` reads (unlike the XenServer equivalents, which `DiscovererBase.buildConfigParams()` does wire through correctly). Only `Ovm3ConfigurationTest.java` sets these two keys manually in its test params map, masking the fact that production code never populates them. This predates the #10752 migration entirely — the same two dead entries existed in the old `Config` enum under the same names — so it's pre-existing dead wiring, not something introduced by this PR. Since these two ConfigKeys have no live consumer, they're also candidates for the safe-deletion sweep this issue tracks (in addition to the enum-side dead values already in scope). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
