nagaboinaramgopal opened a new pull request, #14022:
URL: https://github.com/apache/cloudstack/pull/14022
### Description
`ProjectResponse.setVpcLimit(String vpcLimit)` ignored its argument and
assigned
the `networkLimit` field instead:
public void setVpcLimit(String vpcLimit) {
this.vpcLimit = networkLimit; // should be vpcLimit
}
**Actual behaviour:** `listProjects` reports a project's `vpclimit` equal to
its
`networklimit` (and `null` if `setVpcLimit` runs before `setNetworkLimit`).
**Expected behaviour:** `vpclimit` reflects the project's real VPC limit,
independent of the network limit.
Every sibling setter in the class assigns its own parameter; this one was a
copy-paste slip. Fix: assign the `vpcLimit` parameter.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### How Has This Been Tested?
- Added a unit test (`ProjectResponseTest`) asserting `setVpcLimit` stores
its own
value and leaves `networkLimit` untouched.
- Built standard `.deb` packages and deployed a KVM advanced zone; confirmed
`listProjects` returns the correct, independent `vpclimit`.
#### How did you try to break this feature and the system with this change?
Set different network and VPC limits on a project and verified via
`listProjects`
that `vpclimit` reflects the VPC limit — including when the VPC limit is set
before the network limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
