nagaboinaramgopal opened a new pull request, #14024:
URL: https://github.com/apache/cloudstack/pull/14024

   ### Description
   
   When a VM is restored, `getRootVolumeSizeForVmRestore` reads the requested 
min
   and max IOPS from the volume details, but a copy-paste slip assigned the max
   IOPS value into the min IOPS field:
   
       if (StringUtils.isNumeric(maxIops)) {
           resizedVolume.setMinIops(Long.parseLong(maxIops));
       }
   
   So `setMinIops` was called twice and `setMaxIops` was never called. The 
result
   is that restoring a VM silently drops the volume's max IOPS QoS setting and
   overwrites min IOPS with the max value. Fixed by assigning the parsed max 
IOPS
   to `setMaxIops`.
   
   ### Types of changes
   
   - [x] Bug fix (non-breaking change which fixes an issue)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [x] Minor
   
   ### How Has This Been Tested?
   
   Added a unit test that restores a volume with min IOPS 500 and max IOPS 2000
   and asserts each field holds its own value. Also built the standard packages
   and deployed on a KVM advanced zone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to