DaanHoogland commented on code in PR #14038:
URL: https://github.com/apache/cloudstack/pull/14038#discussion_r3916996394
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -1203,9 +1203,11 @@ private NicVO checkForRaceAndAllocateNic(final
NicProfile requested, final Netwo
}
if (vo == null) {
- if (requested.getRequestedIPv4() != null) {
+ // requested is null on the common "no explicit IP" deploy
path. Guard it so losing the
+ // IP-allocation race retries the allocation instead of
throwing a NullPointerException.
Review Comment:
this comment is cluttering. can you move it to javadoc , possibly on a new
method or remove it completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
