DaanHoogland commented on code in PR #14040:
URL: https://github.com/apache/cloudstack/pull/14040#discussion_r3917072852
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentAttache.java:
##########
@@ -532,11 +532,15 @@ protected synchronized void sendNext(final long seq) {
logger.debug(LOG_SEQ_FORMATTED_STRING, req.getSequence(), "Sending
now. is current sequence.");
try {
send(req);
+ _currentSequence = req.getSequence();
} catch (AgentUnavailableException e) {
logger.debug(LOG_SEQ_FORMATTED_STRING, req.getSequence(), "Unable
to send the next sequence");
cancel(req.getSequence());
+ // The failed command was cancelled, so no answer will ever drive
sendNext again.
+ // Move on to the next queued request instead of parking
_currentSequence on the dead
+ // sequence, which would stall every later in-sequence command to
this host.
Review Comment:
can you remove the superfluent comment?
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
