wido commented on PR #14041: URL: https://github.com/apache/cloudstack/pull/14041#issuecomment-5514685921
> Thanks @wido - largely looks good. Just a question, are we keeping the schema upgrade SQL path files named as before or those should also be updated? Good one. I only did a search and replace, but these files need to be renamed indeed. Let me check that and push a new commit if needed > Most changes have been taken care of. Just wondering if we also need to look at the ci workflow here: https://github.com/apache/cloudstack/blob/main/.github/workflows/docker-cloudstack-simulator.yml#L24-L26 - it only triggers the docker image build on tags matching 4.* / 5.*, so once we start tagging releases as 24.0.0 etc, this workflow won't pick it up and the image build would just silently not run. > > Also, since we've been following the 4.x naming for several years, its pretty likely contributors may keep writing since = "4.24.0" out of muscle memory despite this being communicated. Do you think it makes sense / would help to add a pre-commit hook to catch that automatically instead of relying on reviewers to spot it every time? This could be done on a separate PR too - we could add the hook to .pre-commit-config.yaml That pre-commit hook looks good, can you make a PR for this? I'm not really a big commit hook genius :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
