Copilot commented on code in PR #14044:
URL: https://github.com/apache/cloudstack/pull/14044#discussion_r3923751363
##########
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/CreateKubernetesClusterCmd.java:
##########
@@ -117,16 +117,16 @@ public class CreateKubernetesClusterCmd extends
BaseAsyncCreateCmd {
@ACL(accessType = AccessType.UseEntry)
@Parameter(name = ApiConstants.NODE_TYPE_OFFERING_MAP, type =
CommandType.MAP,
description = "(Optional) Node Type to Service Offering ID
mapping. If provided, it overrides the serviceofferingid parameter. " +
- "Example:
nodeofferings[0].node=\"control\"&nodeofferings[0].offering=\"<service-offering-uuid>\"&"
+
-
"nodeofferings[1].node=\"worker\"&nodeofferings[1].offering=\"<service-offering-uuid>\"",
+ "Example:
nodeofferings[0].node='control'&nodeofferings[0].offering='<service-offering-uuid>'&"
+
+
"nodeofferings[1].node='worker'&nodeofferings[1].offering='<service-offering-uuid>'",
Review Comment:
The example values are wrapped in single quotes (e.g., node='control',
offering='<uuid>'). In an actual API request those quotes would be part of the
parameter value and can make the request fail (unlike the other examples in
this class, e.g. cniconfigdetails, which do not quote values). Consider
removing quotes entirely while keeping the example readable.
This issue also appears on line 127 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
