weizhouapache commented on PR #13902: URL: https://github.com/apache/cloudstack/pull/13902#issuecomment-5529778963
> > > I'm concerned about why we merged a PR that was visibly failing all Simulator CI jobs. Not sure maybe we should look into repository rulesets for branch protection > > > > > > good idea ! > > I am in favour in principle, but am a bit worried that our many false positives are going to impede our (already not so great) velocity. In this case the change was text only and the build passed. We have a usually failing Sonar check and also coverage is not passing. So what will be the requirements that we do impose? ¿ > > * rat > * lint/pre-commit > * build > * codeql > * test-matrix > ? we can start with a minimum set - Build / build (pull_request) - License Check / build (pull_request) - pre-commit / Run pre-commit (pull_request) - Simulator CI / build (pull_request) - UI Build / build (pull_request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
