Copilot commented on code in PR #14107:
URL: https://github.com/apache/cloudstack/pull/14107#discussion_r3974098132
##########
.pre-commit-config.yaml:
##########
@@ -216,3 +216,10 @@ repos:
types: [yaml]
files: \.ya?ml$
exclude: ^.*k8s-.*\.ya?ml$|^.github/workflows/.*\.lock\.ya?ml$
+ - repo: https://github.com/python-jsonschema/check-jsonschema
+ rev: 12e63946db2c5cfcc9030fac21c3883ba88c6ed8 # frozen: 0.38.0
+ hooks:
+ - id: check-dependabot
+ name: validate dependabot.yml
+ description: ensures the dependabot config file is valid
Review Comment:
`description` is not a supported key in `.pre-commit-config.yaml` hook
configuration and will cause `pre-commit` to fail config validation (unexpected
key). Remove this field (or convert it to a YAML comment) and keep the
supported metadata like `name`.
##########
.pre-commit-config.yaml:
##########
@@ -216,3 +216,10 @@ repos:
types: [yaml]
files: \.ya?ml$
exclude: ^.*k8s-.*\.ya?ml$|^.github/workflows/.*\.lock\.ya?ml$
+ - repo: https://github.com/python-jsonschema/check-jsonschema
+ rev: 12e63946db2c5cfcc9030fac21c3883ba88c6ed8 # frozen: 0.38.0
+ hooks:
+ - id: check-dependabot
+ name: validate dependabot.yml
+ description: ensures the dependabot config file is valid
+ files: ^\.github/dependabot\.yml$
Review Comment:
This only matches `.github/dependabot.yml`, but Dependabot configs are also
commonly named `.github/dependabot.yaml`. Consider widening the regex to match
both extensions (e.g., `dependabot\.ya?ml`) to avoid missing validation when
the alternative extension is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
