Damans227 commented on PR #13895:
URL: https://github.com/apache/cloudstack/pull/13895#issuecomment-5611824993

   one unrelated thing i hit while testing this, `TemplateManagerImpl:2449` has 
the join args backwards so an invalid templatetype prints the array object:
   
   ```
   $ cmk register template ... templatetype=BOGUS
   Error: (HTTP 431, error code 4350) Please specify a valid templatetype: 
,[Lcom.cloud.storage.Storage$TemplateType;@d54b45e
   ```
   
   `StringUtils.join(",", TemplateType.values())` should be 
`StringUtils.join(TemplateType.values(), ",")`.
   
   not yours, but its the same area. want to pick it up here or leave it?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to