sureshanaparti commented on code in PR #13941:
URL: https://github.com/apache/cloudstack/pull/13941#discussion_r3976474809
##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/StorageVMSnapshotStrategy.java:
##########
@@ -423,18 +423,19 @@ protected void revertDiskSnapshot(VMSnapshot vmSnapshot) {
}
}
+ /**
+ * Creates a disk (volume) snapshot for one volume of a VM snapshot in
progress.
+ * The payload is always given {@code quiescevm=false}: by this point the
whole VM is
+ * already frozen via {@link FreezeThawVMCommand}, and {@code
DefaultSnapshotStrategy}
+ * rejects {@code quiescevm=true} for volume snapshots.
+ */
protected SnapshotInfo createDiskSnapshot(VMSnapshot vmSnapshot,
List<SnapshotInfo> forRollback, VolumeInfo vol) {
String snapshotName = vmSnapshot.getId() + "_" + vol.getUuid();
SnapshotVO snapshot = new SnapshotVO(vol.getDataCenterId(),
vol.getAccountId(), vol.getDomainId(), vol.getId(), vol.getDiskOfferingId(),
snapshotName, (short)
Snapshot.Type.GROUP.ordinal(), Snapshot.Type.GROUP.name(), vol.getSize(),
vol.getMinIops(), vol.getMaxIops(), Hypervisor.HypervisorType.KVM, null);
- VMSnapshotOptions options = ((VMSnapshotVO) vmSnapshot).getOptions();
- boolean quiescevm = false;
- if (options != null) {
- quiescevm = options.needQuiesceVM();
- }
snapshot = snapshotDao.persist(snapshot);
- vol.addPayload(setPayload(vol, snapshot, quiescevm));
+ vol.addPayload(setPayload(vol, snapshot, false));
Review Comment:
@DaanHoogland any doc update required for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
