Copilot commented on code in PR #14150:
URL: https://github.com/apache/cloudstack/pull/14150#discussion_r4003211650
##########
server/src/main/java/com/cloud/projects/ProjectManagerImpl.java:
##########
@@ -449,7 +449,7 @@ public Boolean doInTransaction(TransactionStatus status) {
@Override
public boolean unassignAccountFromProject(long projectId, long accountId) {
- ProjectAccountVO projectAccount =
_projectAccountDao.findByProjectIdAccountId(projectId, accountId);
+ ProjectAccountVO projectAccount =
_projectAccountDao.findByProjectIdUserId(projectId, accountId, null);
Review Comment:
The null-wildcard behavior is the regression fix, but there is no automated
test covering it: `ProjectManagerImplTest` does not exercise
`unassignAccountFromProject` or project cleanup, and there is no
`ProjectAccountDao` test. Please add a regression test with a project-account
row whose `user_id` is non-null and verify cleanup removes it, so #12601 cannot
recur unnoticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
