abh1sar commented on code in PR #14162:
URL: https://github.com/apache/cloudstack/pull/14162#discussion_r4004526652
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckVolumeCommandWrapper.java:
##########
@@ -64,13 +65,19 @@ public Answer execute(final CheckVolumeCommand command,
final LibvirtComputingRe
if
(STORAGE_POOL_TYPES_SUPPORTED.contains(storageFilerTO.getType())) {
final KVMPhysicalDisk vol = pool.getPhysicalDisk(srcFile);
final String path = vol.getPath();
- try {
- KVMPhysicalDisk.checkQcow2File(path);
- } catch (final CloudRuntimeException e) {
- return new CheckVolumeAnswer(command, false, "", 0,
getVolumeDetails(pool, vol));
+ final boolean isRbd =
Storage.StoragePoolType.RBD.equals(storageFilerTO.getType());
+
+ if (!isRbd) {
Review Comment:
qemu can't check raw files, but I have added code to verify that
getVolumeDetails is able to read the rbd volume as a check.
https://github.com/apache/cloudstack/pull/14162/changes/8f49d1a14a967d30f1a63a43c45690debf22c217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
