Copilot commented on code in PR #14033:
URL: https://github.com/apache/cloudstack/pull/14033#discussion_r4015899332
##########
engine/schema/templateConfig.sh:
##########
@@ -64,7 +74,7 @@ function getChecksum() {
function createMetadataFile() {
local fileData=$(cat "$SOURCEFILE")
- echo -e "["default"]\nversion =
$VERSION.${securityversion}\ndownloadrepository = $CS_SYSTEMTEMPLATE_REPO\n" >>
"$METADATAFILE"
+ echo -e "["default"]\nversion = $FULL_VERSION\ndownloadrepository =
$CS_SYSTEMTEMPLATE_REPO\n" >> "$METADATAFILE"
Review Comment:
For a new-versioning release this writes `version = 24.0.0`, but
`scripts/installer/export-templates.sh:21-24` derives the template filename
prefix by stripping the last dot (`VERSION="${TEMPLATE_VERSION%.*}"`), yielding
`systemvmtemplate-24.0` while the generated files are
`systemvmtemplate-24.0.0-*`. Exporting/converting the generated templates will
therefore select the wrong prefix; update that consumer or preserve a metadata
shape it can parse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
