winterhazel commented on PR #12190: URL: https://github.com/apache/cloudstack/pull/12190#issuecomment-5832068945
@guillemtp @nvazquez @shwstppr @vladimirpetrov this change will impact existing CPU-cap enabled VMs. We need to make a few adjustments before including it in a release. This host frequency is used to calculate the CPU quota of VMs. Considering a host that has a base frequency of 2.9 GHz and max of 4.8 GHz, a VM with a CPU-cap enabled offering with 2.9 GHz currently does not have its CPU time limited. After this change, once the VM is recreated in KVM, it will be able to use ~60% of the CPU's time at maximum, possibly making users feel that their VM performance degraded out of nowhere. I think it is better to introduce this change like this: - Introduce a global setting that keeps the existing behavior for the next minors and major 24. - On major 25, flip the default value of this global setting to change the default behavior. This way, existing environments on a version <= 4.23 will not be affected unless operators are aware of this behavior. New environments will get the new behavior. Also, can someone check whether disabling the CPU frequency boosting features and configuring its minimum/maximum to the base frequency makes `CPU max MHz` return the base frequency? I do not have access to a host which I can perform this test right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
