DaanHoogland commented on code in PR #14036:
URL: https://github.com/apache/cloudstack/pull/14036#discussion_r4142231978
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##########
@@ -1768,7 +1768,7 @@ private void
copyNewSnapshotToZonesOnPrimary(CreateSnapshotPayload payload, Snap
}
}
- private boolean copySnapshotOnPool(SnapshotInfo snapshot, SnapshotStrategy
snapshotStrategy, Long storagePoolId) {
+ protected boolean copySnapshotOnPool(SnapshotInfo snapshot,
SnapshotStrategy snapshotStrategy, Long storagePoolId) {
Review Comment:
```suggestion
boolean copySnapshotOnPool(SnapshotInfo snapshot, SnapshotStrategy
snapshotStrategy, Long storagePoolId) {
```
we can make it package private as the test should be from the same package
anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
