Damans227 commented on code in PR #13490:
URL: https://github.com/apache/cloudstack/pull/13490#discussion_r4158491773
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -5312,18 +5439,18 @@ public NetworkPermissionsResponse
createNetworkPermissionsResponse(NetworkPermis
return response;
}
- protected void handleCertificateResponse(String certStr,
DirectDownloadCertificateResponse response) {
+protected void handleCertificateResponse(String certStr,
DirectDownloadCertificateResponse response) {
Review Comment:
ok thats fixed, thanks
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -5312,18 +5439,18 @@ public NetworkPermissionsResponse
createNetworkPermissionsResponse(NetworkPermis
return response;
}
- protected void handleCertificateResponse(String certStr,
DirectDownloadCertificateResponse response) {
+protected void handleCertificateResponse(String certStr,
DirectDownloadCertificateResponse response) {
try {
- Certificate cert = CertificateHelper.buildCertificate(certStr);
- if (cert instanceof X509CertImpl) {
- X509CertImpl certificate = (X509CertImpl) cert;
+ java.security.cert.Certificate cert =
CertificateHelper.buildCertificate(certStr);
Review Comment:
ok that covers it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
