stag7824 commented on issue #13944:
URL: https://github.com/apache/cloudstack/issues/13944#issuecomment-5948424614
Thank you for the careful re-test, @ms30063600 — you were right and I was
looking in the wrong place. My earlier note was about the Resource Limits
*edit* tab; your screenshots are the usage view, which reads its values from
`listDomains` rather than `listResourceLimits`, and that is where the bug is.
`DomainJoinDaoImpl` resolved the bucket and object storage limits through
the *account* helper, `ApiDBUtils.findCorrectResourceLimit`, passing it the
domain's id. That looks the id up in the account table, finds the root admin or
nothing, and answers unlimited either way — so the configured value was never
used. Every other resource type there already used the domain helper. One small
correction to the report: in your screenshot the unlimited rows are **Bucket
(14)** and **Object Storage (15)**; GPU (16) shows 167 correctly.
There were also copy-paste mistakes in the backup rows (the backup limit was
hidden whenever *snapshots* were unlimited, and backup storage whenever
*backups* were). Your test didn't hit those because every limit was set, but
they would show up on a domain with some limits left unlimited.
All three are fixed in #14293, with tests.
I still can't explain the VPC row in your first screenshot ("77 Available"
but "0 / 67") — both numbers come from the same variable in this code, so it
isn't from here. If you can reproduce it, the raw `listDomains` response for
that domain would show whether `vpclimit` really comes back as 67.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
