Pearl1594 commented on PR #12619: URL: https://github.com/apache/cloudstack/pull/12619#issuecomment-5950884109
> > A little late in reviewing this - not sure if this was already discussed, but, can we not reuse the existing `create-kubernetes-binaries-iso.sh` script, and add cilium version param to it rather than have an explicit script: > > ``` > > create-kubernetes-binaries-iso.sh OUTPUT_PATH K8S_VER CNI_VER CRICTL_VER NETWORK_YAML_URL HEADLAMP_VER BUILD_NAME [ARCH] [ETCD_VER] [CILIUM_VER] > > ``` > > you seem to ask for a change but (in your humility) marked it as a plain comment. Am I right @Pearl1594 ? I would prefer a change/ if we could have one script yes @DaanHoogland. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
