Damans227 commented on code in PR #14247:
URL: https://github.com/apache/cloudstack/pull/14247#discussion_r4168166563
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3613,13 +3613,15 @@ public synchronized String attachOrDetachDisk(final
Connect conn,
if (disk.getDeviceType() == DeviceType.DISK) {
if (disk.getBusType() == DiskDef.DiskBus.SCSI) {
busT = DiskDef.DiskBus.SCSI;
+ } else if (disk.getBusType() ==
DiskDef.DiskBus.VIRTIOBLK) {
Review Comment:
can this ever match now? the running vm reports these disks back as plain
virtio, so a disk added this way still loses discard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
