shwstppr commented on code in PR #12336:
URL: https://github.com/apache/cloudstack/pull/12336#discussion_r4187496720
##########
client/conf/messages/error-messages.json.in:
##########
@@ -0,0 +1,732 @@
+{
Review Comment:
@harikrishna-patnala that won't be possible due a couple of reasons:
- There is not always 1:1 mapping between the API and the error message.
Many APIs may use the same underlying method, returning same message
- For the above reason, we are using the error key structure defined here,
https://cwiki.apache.org/confluence/spaces/CLOUDSTACK/pages/406618482/Error+Message+Consistency+Customization+and+Localization+Framework#ErrorMessageConsistency%2CCustomization%2CandLocalizationFramework-TemplateFormat.
So essentially error messages are grouped with resource type and actions
Also, with the recent changes, operator can use multiple error message JSON
files and group desired keys in different files for override which is defined
here,
https://cwiki.apache.org/confluence/spaces/CLOUDSTACK/pages/406618482/Error+Message+Consistency+Customization+and+Localization+Framework#ErrorMessageConsistency%2CCustomization%2CandLocalizationFramework-PluginandOperatorOverrides
and also in doc PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
