stag7824 commented on PR #14163: URL: https://github.com/apache/cloudstack/pull/14163#issuecomment-6010111781
@DaanHoogland thanks for checking. It only shows on the **Configure limits** tab: Domains (or Accounts) → pick one → Configure limits → scroll to the row between "Max. secondary storage (GiB)" and "Max. Backup Storage (GiB)". On an unmodified 4.22 UI that row is labelled with the literal key `label.maxbackup`. With this change it reads "Max. Backups". I ran the unmodified 4.22 UI locally against the QA backend to check, and I'll attach the two screenshots (before and after) to this comment. You couldn't see it on `qa.cloudstack.cloud/simulator/` because that site serves an older UI. Its `en.json` still has `label.maxbackup` and no `label.maxbackups`. The regression comes from #11587 (973819d, first in 4.22.0.0): it renamed `label.maxbackup` to `label.maxbackups` for the new backup schedule list and did not update the limits tab, which still looks up the singular key. That is also why both keys are needed, as in my earlier reply: the schedule list builds `label.maxbackups` from its `maxbackups` field, and the limits tab builds `label.maxbackup` from the `backup` resource type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
