Damans227 commented on code in PR #14132:
URL: https://github.com/apache/cloudstack/pull/14132#discussion_r4199415258
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##########
@@ -450,6 +450,7 @@ public AsyncCallFuture<VolumeApiResult>
expungeVolumeAsync(VolumeInfo volume) {
future.complete(result);
return future;
}
+ deletePrimaryOnlySnapshotsBeforeRbdVolumeDelete(vol);
Review Comment:
makes sense, keeping the counts and events right is worth it. should we add
a line in the docs so ceph users know the snapshots go first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
