Damans227 commented on code in PR #14330:
URL: https://github.com/apache/cloudstack/pull/14330#discussion_r4210459947


##########
systemvm/debian/opt/cloud/bin/cs/CsAddress.py:
##########
@@ -460,6 +460,8 @@ def fw_router(self):
                         "-A POSTROUTING " +
                         "-p udp -m udp --dport 68 -j CHECKSUM 
--checksum-fill"])
 
+        self.fw.append(["raw", "", "-A PREROUTING -p tcp -m tcp --dport 21 -j 
CT --helper ftp"])

Review Comment:
   good point, a port forward like 2121 to the vm's port 21 missed it. those 
now get the helper on their public port too, in 949c9038fa



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to