sathvikaragi commented on code in PR #14219:
URL: https://github.com/apache/cloudstack/pull/14219#discussion_r4218901978
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java:
##########
@@ -56,7 +56,7 @@ public class UpdateStoragePoolCmd extends BaseCmd {
@Parameter(name = ApiConstants.CAPACITY_IOPS, type = CommandType.LONG,
required = false, description = "IOPS CloudStack can provision from this
storage pool")
Review Comment:
Good catch! We already have this change done as a part of another PR which
is in pipeline, but we can put it in this PR.
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java:
##########
@@ -56,7 +56,7 @@ public class UpdateStoragePoolCmd extends BaseCmd {
@Parameter(name = ApiConstants.CAPACITY_IOPS, type = CommandType.LONG,
required = false, description = "IOPS CloudStack can provision from this
storage pool")
private Long capacityIops;
- @Parameter(name = ApiConstants.CAPACITY_BYTES, type = CommandType.LONG,
required = false, description = "Bytes CloudStack can provision from this
storage pool")
+ @Parameter(name = ApiConstants.CAPACITY_BYTES, type = CommandType.LONG,
required = false, description = "Bytes CloudStack can provision from this
storage pool",validations={ApiArgValidator.PositiveNumber})
Review Comment:
Sure, I agree API-level validation should be consistent, so I’ll add the
same validation to createStoragePool here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
