Damans227 commented on code in PR #14131:
URL: https://github.com/apache/cloudstack/pull/14131#discussion_r4221017356
##########
server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java:
##########
@@ -2348,6 +2421,12 @@ public LoadBalancer
updateLoadBalancerRule(UpdateLoadBalancerRuleCmd cmd) {
throw new
InvalidParameterValueException(String.format("Modifications in lb rule %s are
not supported.", lb));
}
+ // The settings are written straight to the details table, unlike the
fields above that wait
+ // for _lbDao.update, so they are stored only once nothing else can
reject the update
+ Map<String, String> settingsBackup = getConnectionSettings(lbRuleId);
+ boolean settingsChanged =
updateLoadBalancerConnectionSettings(lbRuleId, cmd.getKeepAlive(),
cmd.getIdleTimeout(), cmd.getKeepAliveTimeout(),
Review Comment:
the build is red here: UpdateLoadBalancerTest.testValidateRuleBeforeUpdateLB
crashes because its command has no rule id. can we set the id in that test?
https://github.com/apache/cloudstack/actions/runs/37645766377/job/112876606063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
