weizhouapache commented on PR #14281: URL: https://github.com/apache/cloudstack/pull/14281#issuecomment-6315035060
> > @DaanHoogland as we discussed offline, it is expected that `NetworkGarbageCollector can tear down a network with a live Running VR` > > remind me of the full discussion @weizhouapache; Do we need to teardown the VR first? Should I continue with this line of fixing the issue or abandon the PR? > the NetworkGarbageCollector will shutdown the network if there is no USER vms running after a period. as part of the network shutdown, the running VR will be stopped. hence, there is no issue if the VR is Running > As I understand the edge case here is that a VR is running while no VMs are and we need to tear down the network it services. This is not exactly what @Pearl1594 describes in #14177 so we still need to look for the gaps. From her proposed solutions, what is missing here is: > > * On VM power-state resync to Running after a missing-VM event, reconcile the NIC (broadcast_uri/isolation_uri/state=Reserved) and restore nics_count. this makese sense. > * Include the VirtualRouter's own NIC in nics_count from network creation this does not make sense. > > agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
