weizhouapache commented on code in PR #14357:
URL: https://github.com/apache/cloudstack/pull/14357#discussion_r4336377904
##########
server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java:
##########
@@ -116,6 +117,8 @@ public class NetworkACLServiceImpl extends ManagerBase
implements NetworkACLServ
private VpcManager vpcManager;
private String supportedProtocolsForAclRules = "tcp,udp,icmp,all";
+ private static final int TCP_PROTO_NUMBER = 6;
+ private static final int UDP_PROTO_NUMBER = 17;
Review Comment:
can you move to NetUtils.java ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
