Damans227 commented on PR #14089:
URL: https://github.com/apache/cloudstack/pull/14089#issuecomment-6324523651
Tested on a 4.20 KVM lab (NFS primary storage, one host) with the SL-JID
19624 packages.
### Test:
Deploy a VM and snapshot its ROOT disk twice with the same name. Then use
the same name on a data disk, again after deleting the first snapshot, and take
snapshots with no name, two of them in the same second.
**Before:** plain 4.20 (the PR's classes swapped out). Both snapshots are
accepted:
dupbefore 8331294e-cb1f-4774-ac9d-e1ea8ee5081e BackedUp
dupbefore f20b4bc0-a018-42ce-a28c-5039ab387388 BackedUp
On KVM with NFS each one still got its own file, so the overwrite from the
issue didnt show up here.
**After:** the second one is refused:
2026-10-21 19:05:07,203 INFO [c.c.a.ApiServer] (logid:6893d4e1) A
snapshot with name [dup14089] already exists for volume VolumeObject
{..."name":"ROOT-3"...}
The same name on another volume works. The name can be used again after the
first snapshot is deleted. Snapshots with no name still work, including two in
the same second that got the same auto name (vm14089_data14089_20261021190721).
@rootnomad can the error show just the volume name? right now it prints the
whole volume object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
