DaanHoogland commented on code in PR #14279:
URL: https://github.com/apache/cloudstack/pull/14279#discussion_r4345590191
##########
framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java:
##########
@@ -1409,14 +1410,14 @@ private static DataSource
getDefaultDbcpDataSource(final String database) {
return new PoolingDataSource(connectionPool);
}
- private static String getDBHAParams(String dbName, Properties dbProps) {
+ private static String getDBHAParams(String dbName, Properties dbProps,
String loadBalanceStrategy) {
Review Comment:
@nabassa1323 , @weizhouapache is right, if this is the only place it needs
to be loaded, it doesn't have to be on the parameter list. Can you apply or
rebuke?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
