DaanHoogland opened a new pull request, #14467: URL: https://github.com/apache/cloudstack/pull/14467
### Description Declares a `ConfigKey` for every remaining entry of the deprecated `Config` enum and registers each one in its owner's `getConfigKeys()`. The enum entries stay in place and no call site changes; the only runtime effect is that the keys are registered with the ConfigDepot at startup. The follow-up PRs switch the call sites and the last one deletes the enum entries. Also registers three keys that #13884 moved without registering (`default.page.size`, `check.pod.cidrs`, `cluster.message.timeout.seconds`). That omission is why #13884 failed the simulator CI: `updateConfiguration default.page.size` returned "doesn't exist". Part 1 of 12 of the split of #13884 (phase out the deprecated `Config` enum, #10752). Base: `main`. Every other PR of the split builds on this one. Size: 78 files, +1085/-42. Split overview: foundation → parallel PRs (account, vpn-vpc, snapshot-usage, event-bus, literals) + stacked core-1 … core-5 → enum-removal (last). ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [x] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [x] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> Local verification: full reactor build (checkstyle included) and the unit tests of every touched module pass on this branch; merging all PRs of the split in any order gives no conflicts and reproduces #13884 plus its fixes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
