rootnomad commented on PR #14141: URL: https://github.com/apache/cloudstack/pull/14141#issuecomment-6470103737
Thanks @DaanHoogland. Tested it both ways. Unit on 4.20: `ResourceLimitManagerImplTest` is 57 tests, 0 failures with the fix. Reverting just the one-line precedence change and keeping the new tests, `updateResourceLimitAllowsAResourceDomainAdminToUpdateASubdomain` errors, because the old `(domain match && DOMAIN_ADMIN) || RESOURCE_DOMAIN_ADMIN` wrongly denied a resource domain admin updating a subdomain. The own-domain case stays denied either way. Live on a 4.23 management server, as a resource domain admin updating a subdomain's resource limit: - before the fix: denied, HTTP 531, "Unable to update resource limit for domain <id>, permission denied" - after the fix: allowed, the limit is set on the subdomain Glad to add anything else you'd find useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
