weizhouapache commented on PR #14493: URL: https://github.com/apache/cloudstack/pull/14493#issuecomment-6520719876
> Hi @weizhouapache, I have reviewed PR #14493 and focused on the changes related to built-in Debian 13 templates and Marvin's `get_suitable_test_template()` helper. > > I checked the helper's behavior, its hypervisor-detection logic, and the updated integration tests, including the VM deployment planner and shared-network tests. I also ran three isolated tests for the helper, and all three passed. These tests do not cover a real CloudStack environment. > > I noticed that some test cases explicitly pass the target host or cluster's hypervisor, while others rely on automatic hypervisor detection. I haven't confirmed this as a bug yet. > > Would you recommend investigating this behavior further, or is there another specific area of the PR you'd like me to focus on? @dheeraj12347 Thanks for the review and for testing the helper. Currently, the smoke tests run against only one hypervisor type at a time (KVM, VMware, or Xen). Mixed hypervisor environments with multiple clusters are not covered, so there could be some issues with hypervisor detection in such scenarios. However, I think this is outside the scope of this PR. I would suggest not spending time investigating or fixing the smoke tests for mixed hypervisor environments as part of this PR. If you have time, it would be more helpful to review the build script and test the Debian 13 images I've just uploaded, which will also be synced to download.cloudstack.org. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
