DaanHoogland commented on code in PR #14473:
URL: https://github.com/apache/cloudstack/pull/14473#discussion_r4442588528
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -1872,8 +1872,7 @@ private void checkPodAttributesForNonEdgeZone(final long
podId, final String pod
}
}
- final String checkPodCIDRs = _configDao.getValue("check.pod.cidrs");
- if (checkPodCIDRs == null || checkPodCIDRs.trim().isEmpty() ||
Boolean.parseBoolean(checkPodCIDRs)) {
+ if (ManagementServer.CheckPodCIDRs.value()) {
checkPodCidrSubnets(zone.getId(), podId, cidr);
Review Comment:
it shouldn't. in the end "check.pod.cidrs" is queried and its value
determins the next action. Any reason to think the two methods are not
equivilent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
