piyush5netapp commented on code in PR #14647:
URL: https://github.com/apache/cloudstack/pull/14647#discussion_r4521820064
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1481,6 +1481,22 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws
ResourceAllocationExcep
}
}
+ /**
+ * The resize orchestration (orchestrateResizeVolume) only tells the
hypervisor about a running user VM. For a
+ * system VM the volume is resized on the storage, but the running guest
is not told and keeps seeing the old size
+ * until it next starts. So a system VM's volume can only be resized while
the system VM is stopped.
+ */
+ protected void validateVolumeIsNotOnRunningSystemVm(VolumeVO volume) {
Review Comment:
if the intention is to support resize of system VM only in stopped state,
isn't having stopped in method name makes more sense ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]