RosiKyu commented on PR #13950:
URL: https://github.com/apache/cloudstack/pull/13950#issuecomment-6817088076

   LGTM
   
   Tested the UI build (`@blueorangutan ui`) as root admin:
   
   - Accounts > account `user`: the new "Link account to LDAP" action is shown 
(LDAP enabled); the form opens with domain and account prefilled, Type offers 
GROUP / OU.
   - Account type shows "Normal (User)" and "Domain Admin" instead of `0` / 
`2`, and the selected value is shown as text.
   - Domains > ROOT > "Link domain to LDAP": Account type shows the same 
readable labels.
   - No regression on other generic forms: Add Affinity Group > Type still 
lists its 4 options as before.
   
   Smoke tests on the current code: 157 OK, 0 errors (kvm-ol8). Note: the UI 
build ran against a 4.21.0.0 backend, so the server-side default (Type empty = 
GROUP) is covered by the unit test, not by this UI test. The form was not 
submitted.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to