This is an automated email from the ASF dual-hosted git repository.

DaanHoogland pushed a commit to branch ghi14680-stateCondition
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 33526a6891b9bf32df76b9c87f709ffe34c80f1e
Author: Daan Hoogland <[email protected]>
AuthorDate: Fri Nov 20 14:39:40 2026 +0100

    tests
---
 .../cloud/storage/VolumeApiServiceImplTest.java    | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git 
a/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java 
b/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java
index 401b12ebbf4..5bed36f7c20 100644
--- a/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java
+++ b/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java
@@ -624,6 +624,28 @@ public class VolumeApiServiceImplTest {
         volumeApiServiceImpl.detachVolumeFromVM(detachCmd);
     }
 
+    private void validateRootVolumeDetachAttachForVmInState(State state) {
+        UserVmVO vm = new UserVmVO(7L, "vm", "vm", 1, HypervisorType.KVM, 1L, 
false, false, 1L, 1L, 1, 1L, null, null, null, "vm");
+        vm.setState(state);
+        VolumeVO rootVolume = new VolumeVO("root", 1L, 1L, 1L, 1L, 7L, "root", 
"root", Storage.ProvisioningType.THIN, 1, null, null, "root", Volume.Type.ROOT);
+        ReflectionTestUtils.invokeMethod(volumeApiServiceImpl, 
"validateRootVolumeDetachAttach", rootVolume, vm);
+    }
+
+    @Test
+    public void validateRootVolumeDetachAttachAllowsStoppedVm() {
+        validateRootVolumeDetachAttachForVmInState(State.Stopped);
+    }
+
+    @Test
+    public void validateRootVolumeDetachAttachAllowsDestroyedVm() {
+        validateRootVolumeDetachAttachForVmInState(State.Destroyed);
+    }
+
+    @Test(expected = InvalidParameterValueException.class)
+    public void validateRootVolumeDetachAttachRejectsRunningVm() {
+        validateRootVolumeDetachAttachForVmInState(State.Running);
+    }
+
     /**
      * TESTS FOR ATTACH ROOT VOLUME, COUNT=7
      */

Reply via email to