pavanaravapalli commented on a change in pull request #2072: WIP: 
CLOUDSTACK-9895 : Added support for parallel volume(s) creation from a volume 
snapshot
URL: https://github.com/apache/cloudstack/pull/2072#discussion_r114258213
 
 

 ##########
 File path: 
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
 ##########
 @@ -2025,4 +2037,27 @@ public VolumeInfo 
updateHypervisorSnapshotReserveForVolume(DiskOffering diskOffe
 
         return volFactory.getVolume(volumeId);
     }
+
+    /**
+     *  inserts volume,snapshot details
+     * @param volumeId
+     * @param snapsShotid
+     */
+    public void insertVolumeDetailsVO(Long volumeId,Long snapsShotid)
 
 Review comment:
   This method populates the entity object data and use addDetail method of Dao 
internally. Due to the naming convention it may lead to confusion. However this 
is addressed as per the comment. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to