koushik-das commented on a change in pull request #1832: CLOUDSTACK-9652 Job
framework - Cancelling async jobs
URL: https://github.com/apache/cloudstack/pull/1832#discussion_r114275616
##########
File path:
framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java
##########
@@ -1075,4 +1135,65 @@ private void publishOnEventBus(AsyncJob job, String
jobEvent) {
public List<AsyncJobVO> findFailureAsyncJobs(String... cmds) {
return _jobDao.getFailureJobsSinceLastMsStart(getMsid(), cmds);
}
+
+ @Override
+ public String cancelAsyncJob(long jobId, String reason) {
+ final AsyncJobVO job = _jobDao.findById(jobId);
+ String errString;
Review comment:
It is good idea to initialise to null, improves readability
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
