jayapalu commented on a change in pull request #2086: CLOUDSTACK-9905:VPN Gateway with Public Subnet URL: https://github.com/apache/cloudstack/pull/2086#discussion_r116740052
########## File path: server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java ########## @@ -438,9 +438,6 @@ public Site2SiteCustomerGateway updateCustomerGateway(UpdateVpnCustomerGatewayCm name = "VPN-" + gatewayIp; } String guestCidrList = cmd.getGuestCidrList(); - if (!NetUtils.validateGuestCidrList(guestCidrList)) { Review comment: @mrunalinikankariya we need to check for the isValidCIDR cidr here. If you look at validateGuestCidr method it is checking for the isValidCIDR first then checking for RFC compliant. Also please squash the commits into single commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services