swill commented on a change in pull request #2089: vRouters fixes & performance 
improvement
URL: https://github.com/apache/cloudstack/pull/2089#discussion_r118253815
 
 

 ##########
 File path: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh
 ##########
 @@ -27,39 +27,29 @@ log_it() {
     echo "$(date) : $*" >> $log
 }
 
-while getopts 'c:' OPTION
-do
-  case $OPTION in
-      c) cfg="$OPTARG"
-          ;;
-  esac
-done
+while getopts 'c:' OPTION; do
+    case $OPTION in
+        c) cfg="$OPTARG" ;;
+esac; done
 
 Review comment:
   This one, I agree with Daan.  We are changing the indentation scope which is 
confusing.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to