rafaelweingartner commented on a change in pull request #2185: CLOUDSTACK-9976:
Redirect saml2 failed login message to a configurable URL
URL: https://github.com/apache/cloudstack/pull/2185#discussion_r127548274
##########
File path:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
##########
@@ -303,9 +308,13 @@ public String authenticate(final String command, final
Map<String, Object[]> par
}
if (userAccount == null || userAccount.getExternalEntity() ==
null || !_samlAuthManager.isUserAuthorized(userAccount.getId(),
issuer.getValue())) {
Review comment:
This method is already quite big. What about extracting what you added lines
310-318 to a method?
This enables, docs, test case and a better and clear code to read (in my
opinion).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
