syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r130692538
##########
File path:
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java
##########
@@ -328,7 +329,7 @@ public static void start(Properties conf) {
}
if (httpListenPort != 0) {
- startupHttpMain();
+ startServerForNoVNC();
Review comment:
Can you keep the `startupHttpMain` function and move the logic of
`startServerForNoVNC` into `startupHttpMain` since we are no longer just doing
VNC, we are also doing ajax through the same jetty service
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
