rhtyd commented on a change in pull request #1707: CLOUDSTACK-9397: Add 
Watchdog timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r138802589
 
 

 ##########
 File path: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -870,6 +875,16 @@ public boolean configure(final String name, final 
Map<String, Object> params) th
             _rngRatePeriod = NumbersUtil.parseInt(value, new 
Integer(_rngRatePeriod));
         }
 
+        value = (String) params.get("vm.watchdog.model");
+        if (!Strings.isNullOrEmpty(value)) {
 
 Review comment:
   @GabrielBrascher I think using `isNullOrEmpty` is alright
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to