rhtyd commented on a change in pull request #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#discussion_r139069450
########## File path: server/src/com/cloud/vm/UserVmManagerImpl.java ########## @@ -3619,8 +3619,14 @@ public UserVmVO doInTransaction(TransactionStatus status) throws InsufficientCap _vmDao.persist(vm); for (String key : customParameters.keySet()) { - //handle double byte strings. - vm.setDetail(key, Integer.toString(Integer.parseInt(customParameters.get(key)))); + if( key.equalsIgnoreCase(VmDetailConstants.CPU_NUMBER) || + key.equalsIgnoreCase(VmDetailConstants.CPU_SPEED) || + key.equalsIgnoreCase(VmDetailConstants.MEMORY)) { + // handle double byte strings. + vm.setDetail(key, Integer.toString(Integer.parseInt(customParameters.get(key)))); + } else { Review comment: Fantastic thanks for fixing @nathanejohnson ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services