rhtyd commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate
usage while processing usage events
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r142578406
##########
File path: usage/src/com/cloud/usage/UsageManagerImpl.java
##########
@@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
if (EventTypes.EVENT_VM_START.equals(event.getType())) {
// create a new usage_VM_instance row for this VM
- try {
Review comment:
@jayakarteek can you also addressed any outstanding issue on the PR, and
explain some unanswered questions including - (1) how do we reproduce this
error in a new master based environment, (2) instead of ignoring/stopping at
the exception does it make sense to fix the cases that lead to
throwing/suppression of exceptions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
