jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#discussion_r143700117
########## File path: usage/src/com/cloud/usage/UsageManagerImpl.java ########## @@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) { if (EventTypes.EVENT_VM_START.equals(event.getType())) { // create a new usage_VM_instance row for this VM - try { Review comment: @rhtyd 1 We cannot reproduce the scenario directly, as it depends on usage events. 2 Duplicate usage occurs due to in correct database records and we may not know which scenarios are populating the incorrect values. Ideally it is good to fix the cases that are generating wrong database records. But there may be more then one cases that causes this error, fixing all dependent systems is time consuming and complicated so better to handle here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services